Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oscar: update to 1.6.0, update source repo #367795

Merged
merged 1 commit into from
Dec 27, 2024
Merged

oscar: update to 1.6.0, update source repo #367795

merged 1 commit into from
Dec 27, 2024

Conversation

pcboy
Copy link
Contributor

@pcboy pcboy commented Dec 24, 2024

Updating Oscar to 1.6.0

The repository changed owner. See this commit:

https://gitlab.com/pholy/OSCAR-code/-/commit/d16e40388d7b4dcbfc97afef85df43c520a03ccb

So now it's https://gitlab.com/CrimsonNape/OSCAR-code.git .
Version is 1.6.0 on this one.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@pcboy pcboy marked this pull request as ready for review December 24, 2024 04:28
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 24, 2024
@ofborg ofborg bot requested a review from roconnor December 24, 2024 14:30
roconnor
roconnor approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@roconnor roconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 26, 2024
@donovanglover
Copy link
Member

Commit message should be oscar: 1.5.3 -> 1.6.0

@pcboy pcboy force-pushed the update-oscar-1.6.0 branch from 2cfeea1 to 7332711 Compare December 27, 2024 11:52
@pcboy
Copy link
Contributor Author

pcboy commented Dec 27, 2024

@donovanglover Commit message fixed.

@ofborg ofborg bot requested a review from roconnor December 27, 2024 12:34
@donovanglover donovanglover merged commit c7d8be9 into NixOS:master Dec 27, 2024
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donovanglover donovanglover donovanglover approved these changes

@roconnor roconnor Awaiting requested review from roconnor

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pcboy @donovanglover @roconnor @wegank